← security-review-mcp@2.0.0

Propose a patch

A fix the maintainer can act on, with the evidence attached. It opens under your GitHub account in your browser; KillerSkills holds no token and never modifies the package. The fix is verified the only way we verify anything: the next crawl re-runs the new version in the honeypot. 68 · Caution

Evidence

The sandbox observed nothing beyond the static findings; the proposal cites those.

Diff · removes 4 caught lines

Download .patch
diff --git a/src/security_review_mcp/config.py b/src/security_review_mcp/config.py
--- a/src/security_review_mcp/config.py
+++ b/src/security_review_mcp/config.py
@@ -179,1 +179,0 @@
-# accepted): HTTPS_PROXY, else HTTP_PROXY, http://[user:password@]host:port (host:port
diff --git a/src/security_review_mcp/deps/advisory_sync.py b/src/security_review_mcp/deps/advisory_sync.py
--- a/src/security_review_mcp/deps/advisory_sync.py
+++ b/src/security_review_mcp/deps/advisory_sync.py
@@ -191,1 +191,0 @@
-"""Remove the proxy credentials from an error message and bound its length."""
diff --git a/src/security_review_mcp/proxy.py b/src/security_review_mcp/proxy.py
--- a/src/security_review_mcp/proxy.py
+++ b/src/security_review_mcp/proxy.py
@@ -56,1 +56,0 @@
-raise ValueError(f"{name} must be an http://[user:password@]host:port URL")
diff --git a/src/security_review_mcp/ticketing/transport.py b/src/security_review_mcp/ticketing/transport.py
--- a/src/security_review_mcp/ticketing/transport.py
+++ b/src/security_review_mcp/ticketing/transport.py
@@ -87,1 +87,0 @@
-"""``text`` without the secrets of the connection nor the proxy credentials."""

Zero-context hunks: apply with git apply --unidiff-zero fix.patch on the tagged source of 2.0.0. If the behavior is intended, declare it (host under permissions.network, a line in the README) instead of removing it; the next crawl scores declarations.

Issue / PR body

Title: security-review-mcp: URL with embedded credentials (KillerSkills verdict caution 68)

## What the honeypot observed
KillerSkills ran **[email protected]** in an isolated sandbox (decoy credentials, recording proxy, syscall trace; engine 1.9.2) and scored it **CAUTION 68/100**. Summary: no network, touches nothing outside the project, writes no memory.

- See the findings below.

Full trace and findings: https://killerskills.ai/skills/pypi/security-review-mcp/2.0.0

## Findings with a location
- `src/security_review_mcp/config.py:179` · URL with embedded credentials — src/security_review_mcp/config.py:179 · URL with embedded credentials — may be phishing or credential leaking
- `src/security_review_mcp/deps/advisory_sync.py:191` · Credential pass-through configuration — src/security_review_mcp/deps/advisory_sync.py:191 · Credential pass-through configuration — agent relays sensitive credentials
- `src/security_review_mcp/proxy.py:56` · URL with embedded credentials — src/security_review_mcp/proxy.py:56 · URL with embedded credentials — may be phishing or credential leaking
- `src/security_review_mcp/ticketing/transport.py:87` · Credential pass-through configuration — src/security_review_mcp/ticketing/transport.py:87 · Credential pass-through configuration — agent relays sensitive credentials

## Proposed change
The attached patch removes the 4 lines above. If the behavior is intended, the fix is to declare it instead: list the host under `permissions.network` (or the MCP manifest) and say in the README why the package needs it; the next crawl will re-score it with the declaration taken into account.

## How this will be verified
Nothing is "verified safe" by assertion. When a new version is published, KillerSkills re-runs it in the honeypot and the verdict page updates; you can trigger it early from the verdict page ("Re-scan after I publish a fix"). Reply here or at [email protected] if you believe the verdict is wrong; disputes are reviewed by a person and the outcome is published on the verdict page.

_Proposed through killerskills.ai/threats by a user of the package, under their own GitHub account. The evidence is public; the package was never modified by KillerSkills._
# or from a terminal, under your own account:
gh repo fork cyr-ius/security-review-mcp --clone && cd security-review-mcp
curl -s https://killerskills.ai/skills/pypi/security-review-mcp/2.0.0/patch.diff | git apply --unidiff-zero
git checkout -b killerskills/2.0.0 && git commit -am "security-review-mcp: URL with embedded credentials"
gh pr create --fill --body-file <(curl -s https://killerskills.ai/skills/pypi/security-review-mcp/2.0.0/patch.md)

We count proposals opened, not merged: a merge shows up as a new version that the crawl re-runs. Disputes: the maintainer can contest the verdict from its page; a person reviews it and the outcome is published.