← mcpfang@0.1.3
Propose a patch
A fix the maintainer can act on, with the evidence attached. It opens under your GitHub account in your browser; KillerSkills holds no token and never modifies the package. The fix is verified the only way we verify anything: the next crawl re-runs the new version in the honeypot. 68 · Caution
Evidence
The sandbox observed nothing beyond the static findings; the proposal cites those.
Diff · removes 8 caught lines
Download .patchdiff --git a/src/mcpfang/cli.py b/src/mcpfang/cli.py --- a/src/mcpfang/cli.py +++ b/src/mcpfang/cli.py @@ -77,1 +77,0 @@ -bedrock_profile: Optional[str] = typer.Option(None, "--bedrock-profile", help="AWS profile name from ~/.aws/credentials (Bedrock provider only)"), @@ -933,1 +932,0 @@ -# Auth uses boto3's default credential chain (env, ~/.aws/credentials, IAM role, SSO). diff --git a/src/mcpfang/playbooks/command_injection.py b/src/mcpfang/playbooks/command_injection.py --- a/src/mcpfang/playbooks/command_injection.py +++ b/src/mcpfang/playbooks/command_injection.py @@ -74,1 +74,0 @@ -- `; cat ~/.ssh/id_rsa` — SSH key theft diff --git a/src/mcpfang/config.py b/src/mcpfang/config.py --- a/src/mcpfang/config.py +++ b/src/mcpfang/config.py @@ -26,1 +26,0 @@ -bedrock_profile: str | None = None # ~/.aws/credentials profile name diff --git a/src/mcpfang/providers/httpx_provider.py b/src/mcpfang/providers/httpx_provider.py --- a/src/mcpfang/providers/httpx_provider.py +++ b/src/mcpfang/providers/httpx_provider.py @@ -394,1 +394,0 @@ -(env vars, ~/.aws/credentials, IAM role, SSO profile). diff --git a/src/mcpfang/playbooks/path_traversal.py b/src/mcpfang/playbooks/path_traversal.py --- a/src/mcpfang/playbooks/path_traversal.py +++ b/src/mcpfang/playbooks/path_traversal.py @@ -64,1 +64,0 @@ -- `~/.ssh/id_rsa` or `../.ssh/id_rsa` — SSH private keys @@ -66,1 +65,0 @@ -- `~/.aws/credentials` — AWS access keys @@ -69,1 +67,0 @@ -- `~/.npmrc` or `~/.pypirc` — package registry tokens
Zero-context hunks: apply with git apply --unidiff-zero fix.patch on the tagged source of 0.1.3. If the behavior is intended, declare it (host under permissions.network, a line in the README) instead of removing it; the next crawl scores declarations.
Issue / PR body
Title: mcpfang: References a credential file in the home directory (KillerSkills verdict caution 68)
## What the honeypot observed KillerSkills ran **[email protected]** in an isolated sandbox (decoy credentials, recording proxy, syscall trace; engine 1.8.1) and scored it **CAUTION 68/100**. Summary: no network, touches nothing outside the project, writes no memory. - See the findings below. Full trace and findings: https://killerskills.ai/skills/pypi/mcpfang/0.1.3 ## Findings with a location - `src/mcpfang/cli.py:933` · References a credential file in the home directory — src/mcpfang/cli.py:933 · References a credential file in the home directory - `src/mcpfang/playbooks/command_injection.py:74` · Reads credential paths from the home directory — src/mcpfang/playbooks/command_injection.py:74 · Reads credential paths from the home directory - `src/mcpfang/cli.py:77` · References a credential file in the home directory — src/mcpfang/cli.py:77 · References a credential file in the home directory - `src/mcpfang/config.py:26` · References a credential file in the home directory — src/mcpfang/config.py:26 · References a credential file in the home directory - `src/mcpfang/playbooks/command_injection.py:74` · References a credential file in the home directory — src/mcpfang/playbooks/command_injection.py:74 · References a credential file in the home directory - `src/mcpfang/providers/httpx_provider.py:394` · References a credential file in the home directory — src/mcpfang/providers/httpx_provider.py:394 · References a credential file in the home directory - `src/mcpfang/playbooks/path_traversal.py:64` · References a credential file in the home directory — src/mcpfang/playbooks/path_traversal.py:64 · References a credential file in the home directory - `src/mcpfang/playbooks/path_traversal.py:66` · References a credential file in the home directory — src/mcpfang/playbooks/path_traversal.py:66 · References a credential file in the home directory - `src/mcpfang/playbooks/path_traversal.py:69` · References a credential file in the home directory — src/mcpfang/playbooks/path_traversal.py:69 · References a credential file in the home directory ## Proposed change The attached patch removes the 8 lines above. If the behavior is intended, the fix is to declare it instead: list the host under `permissions.network` (or the MCP manifest) and say in the README why the package needs it; the next crawl will re-score it with the declaration taken into account. ## How this will be verified Nothing is "verified safe" by assertion. When a new version is published, KillerSkills re-runs it in the honeypot and the verdict page updates; you can trigger it early from the verdict page ("Re-scan after I publish a fix"). Reply here or at [email protected] if you believe the verdict is wrong; disputes are reviewed by a person and the outcome is published on the verdict page. _Proposed through killerskills.ai/threats by a user of the package, under their own GitHub account. The evidence is public; the package was never modified by KillerSkills._
# or from a terminal, under your own account: gh repo fork harishsg993010/damn-vulnerable-MCP-server --clone && cd damn-vulnerable-MCP-server curl -s https://killerskills.ai/skills/pypi/mcpfang/0.1.3/patch.diff | git apply --unidiff-zero git checkout -b killerskills/0.1.3 && git commit -am "mcpfang: References a credential file in the home directory" gh pr create --fill --body-file <(curl -s https://killerskills.ai/skills/pypi/mcpfang/0.1.3/patch.md)
We count proposals opened, not merged: a merge shows up as a new version that the crawl re-runs. Disputes: the maintainer can contest the verdict from its page; a person reviews it and the outcome is published.