Propose a patch

A fix the maintainer can act on, with the evidence attached. It opens under your GitHub account in your browser; KillerSkills holds no token and never modifies the package. The fix is verified the only way we verify anything: the next crawl re-runs the new version in the honeypot. 68 · Caution

Evidence

The sandbox observed nothing beyond the static findings; the proposal cites those.

Diff · removes 6 caught lines

Download .patch

diff --git a/tests/test_client_guards.py b/tests/test_client_guards.py
--- a/tests/test_client_guards.py
+++ b/tests/test_client_guards.py
@@ -22,1 +22,0 @@
-_BASE = "https://operator1:[email protected]"
diff --git a/src/mcp_server_malcolm/errors.py b/src/mcp_server_malcolm/errors.py
--- a/src/mcp_server_malcolm/errors.py
+++ b/src/mcp_server_malcolm/errors.py
@@ -99,1 +99,0 @@
-Strips URL userinfo (``https://user:pw@host`` -> ``https://host``) and the
@@ -104,1 +103,0 @@
->>> redact("GET https://operator1:[email protected]/mapi/fields failed")
diff --git a/src/mcp_server_malcolm/tools/write/pcap_upload.py b/src/mcp_server_malcolm/tools/write/pcap_upload.py
--- a/src/mcp_server_malcolm/tools/write/pcap_upload.py
+++ b/src/mcp_server_malcolm/tools/write/pcap_upload.py
@@ -12,1 +12,0 @@
-could exfiltrate any file the process can read (~/.ssh/id_rsa, ~/.aws/...). If
diff --git a/tests/test_errors.py b/tests/test_errors.py
--- a/tests/test_errors.py
+++ b/tests/test_errors.py
@@ -40,1 +40,0 @@
-"GET https://operator1:[email protected]/mapi/fields -> 401",
@@ -44,1 +43,0 @@
-("https://admin:p%[email protected]/x", "p%40ss", "192.0.2.1"),

Zero-context hunks: apply with git apply --unidiff-zero fix.patch on the tagged source of 1.2.1. If the behavior is intended, declare it (host under permissions.network, a line in the README) instead of removing it; the next crawl scores declarations.

Issue / PR body

Title: mcp-server-malcolm: URL with embedded credentials (KillerSkills verdict caution 68)

## What the honeypot observed
KillerSkills ran **[email protected]** in an isolated sandbox (decoy credentials, recording proxy, syscall trace; engine 1.8.1) and scored it **CAUTION 68/100**. Summary: no network, touches nothing outside the project, writes no memory.

- See the findings below.

Full trace and findings: https://killerskills.ai/skills/pypi/mcp-server-malcolm/1.2.1

## Findings with a location
- `tests/test_client_guards.py:22` · URL with embedded credentials — tests/test_client_guards.py:22 · URL with embedded credentials — may be phishing or credential leaking
- `src/mcp_server_malcolm/errors.py:99` · URL with embedded credentials — src/mcp_server_malcolm/errors.py:99 · URL with embedded credentials — may be phishing or credential leaking
- `src/mcp_server_malcolm/errors.py:104` · URL with embedded credentials — src/mcp_server_malcolm/errors.py:104 · URL with embedded credentials — may be phishing or credential leaking
- `src/mcp_server_malcolm/tools/write/pcap_upload.py:12` · References a credential file in the home directory — src/mcp_server_malcolm/tools/write/pcap_upload.py:12 · References a credential file in the home directory
- `src/mcp_server_malcolm/tools/write/pcap_upload.py:12` · Reads credential paths from the home directory — src/mcp_server_malcolm/tools/write/pcap_upload.py:12 · Reads credential paths from the home directory
- `tests/test_errors.py:40` · URL with embedded credentials — tests/test_errors.py:40 · URL with embedded credentials — may be phishing or credential leaking
- `tests/test_errors.py:44` · URL with embedded credentials — tests/test_errors.py:44 · URL with embedded credentials — may be phishing or credential leaking

## Proposed change
The attached patch removes the 6 lines above. If the behavior is intended, the fix is to declare it instead: list the host under `permissions.network` (or the MCP manifest) and say in the README why the package needs it; the next crawl will re-score it with the declaration taken into account.

## How this will be verified
Nothing is "verified safe" by assertion. When a new version is published, KillerSkills re-runs it in the honeypot and the verdict page updates; you can trigger it early from the verdict page ("Re-scan after I publish a fix"). Reply here or at [email protected] if you believe the verdict is wrong; disputes are reviewed by a person and the outcome is published on the verdict page.

_Proposed through killerskills.ai/threats by a user of the package, under their own GitHub account. The evidence is public; the package was never modified by KillerSkills._

Open the issue on GitHub (nagameTW/mcp-server-malcolm)Fork to open a PR

# or from a terminal, under your own account:
gh repo fork nagameTW/mcp-server-malcolm --clone && cd mcp-server-malcolm
curl -s https://killerskills.ai/skills/pypi/mcp-server-malcolm/1.2.1/patch.diff | git apply --unidiff-zero
git checkout -b killerskills/1.2.1 && git commit -am "mcp-server-malcolm: URL with embedded credentials"
gh pr create --fill --body-file <(curl -s https://killerskills.ai/skills/pypi/mcp-server-malcolm/1.2.1/patch.md)

We count proposals opened, not merged: a merge shows up as a new version that the crawl re-runs. Disputes: the maintainer can contest the verdict from its page; a person reviews it and the outcome is published.