← mcp-agents@0.0.28

Propose a patch

A fix the maintainer can act on, with the evidence attached. It opens under your GitHub account in your browser; KillerSkills holds no token and never modifies the package. The fix is verified the only way we verify anything: the next crawl re-runs the new version in the honeypot. 76 · Caution

Evidence

The sandbox observed nothing beyond the static findings; the proposal cites those.

Diff · removes 12 caught lines

Download .patch
diff --git a/observee_agents/providers/groq_provider.py b/observee_agents/providers/groq_provider.py
--- a/observee_agents/providers/groq_provider.py
+++ b/observee_agents/providers/groq_provider.py
@@ -33,1 +33,0 @@
-raise ValueError("Groq API key is required. Set GROQ_API_KEY environment variable or pass api_key parameter.")
diff --git a/observee_agents/search/cloud_infrastructure.py b/observee_agents/search/cloud_infrastructure.py
--- a/observee_agents/search/cloud_infrastructure.py
+++ b/observee_agents/search/cloud_infrastructure.py
@@ -44,1 +44,0 @@
-raise ValueError("OpenAI API key required. Set OPENAI_API_KEY env var or pass api_key")
@@ -145,1 +144,0 @@
-raise ValueError("Pinecone API key required. Set PINECONE_API_KEY env var or pass api_key")
diff --git a/observee_agents/providers/gemini_provider.py b/observee_agents/providers/gemini_provider.py
--- a/observee_agents/providers/gemini_provider.py
+++ b/observee_agents/providers/gemini_provider.py
@@ -33,1 +33,0 @@
-raise ValueError("Google API key is required. Set GOOGLE_API_KEY environment variable or pass api_key parameter.")
diff --git a/observee_agents_old/providers/groq_provider.py b/observee_agents_old/providers/groq_provider.py
--- a/observee_agents_old/providers/groq_provider.py
+++ b/observee_agents_old/providers/groq_provider.py
@@ -33,1 +33,0 @@
-raise ValueError("Groq API key is required. Set GROQ_API_KEY environment variable or pass api_key parameter.")
diff --git a/observee_agents/auth/mcpauth.py b/observee_agents/auth/mcpauth.py
--- a/observee_agents/auth/mcpauth.py
+++ b/observee_agents/auth/mcpauth.py
@@ -48,1 +48,0 @@
-"or pass api_key parameter."
diff --git a/observee_agents_old/search/cloud_infrastructure.py b/observee_agents_old/search/cloud_infrastructure.py
--- a/observee_agents_old/search/cloud_infrastructure.py
+++ b/observee_agents_old/search/cloud_infrastructure.py
@@ -44,1 +44,0 @@
-raise ValueError("OpenAI API key required. Set OPENAI_API_KEY env var or pass api_key")
@@ -145,1 +144,0 @@
-raise ValueError("Pinecone API key required. Set PINECONE_API_KEY env var or pass api_key")
diff --git a/observee_agents_old/auth/mcpauth.py b/observee_agents_old/auth/mcpauth.py
--- a/observee_agents_old/auth/mcpauth.py
+++ b/observee_agents_old/auth/mcpauth.py
@@ -48,1 +48,0 @@
-"or pass api_key parameter."
diff --git a/observee_agents_old/providers/gemini_provider.py b/observee_agents_old/providers/gemini_provider.py
--- a/observee_agents_old/providers/gemini_provider.py
+++ b/observee_agents_old/providers/gemini_provider.py
@@ -33,1 +33,0 @@
-raise ValueError("Google API key is required. Set GOOGLE_API_KEY environment variable or pass api_key parameter.")
diff --git a/observee_agents_old/providers/openai_provider.py b/observee_agents_old/providers/openai_provider.py
--- a/observee_agents_old/providers/openai_provider.py
+++ b/observee_agents_old/providers/openai_provider.py
@@ -34,1 +34,0 @@
-raise ValueError("OpenAI API key is required. Set OPENAI_API_KEY environment variable or pass api_key parameter.")
diff --git a/observee_agents/providers/openai_provider.py b/observee_agents/providers/openai_provider.py
--- a/observee_agents/providers/openai_provider.py
+++ b/observee_agents/providers/openai_provider.py
@@ -34,1 +34,0 @@
-raise ValueError("OpenAI API key is required. Set OPENAI_API_KEY environment variable or pass api_key parameter.")

Zero-context hunks: apply with git apply --unidiff-zero fix.patch on the tagged source of 0.0.28. If the behavior is intended, declare it (host under permissions.network, a line in the README) instead of removing it; the next crawl scores declarations.

Issue / PR body

Title: mcp-agents: Credential pass-through configuration (KillerSkills verdict caution 76)

## What the honeypot observed
KillerSkills ran **[email protected]** in an isolated sandbox (decoy credentials, recording proxy, syscall trace; engine 1.7) and scored it **CAUTION 76/100**. Summary: no network, touches nothing outside the project, writes no memory.

- See the findings below.

Full trace and findings: https://killerskills.ai/skills/pypi/mcp-agents/0.0.28

## Findings with a location
- `observee_agents/providers/groq_provider.py:33` · Credential pass-through configuration — observee_agents/providers/groq_provider.py:33 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents/search/cloud_infrastructure.py:145` · Credential pass-through configuration — observee_agents/search/cloud_infrastructure.py:145 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents/providers/gemini_provider.py:33` · Credential pass-through configuration — observee_agents/providers/gemini_provider.py:33 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/providers/groq_provider.py:33` · Credential pass-through configuration — observee_agents_old/providers/groq_provider.py:33 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents/search/cloud_infrastructure.py:44` · Credential pass-through configuration — observee_agents/search/cloud_infrastructure.py:44 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents/auth/mcpauth.py:48` · Credential pass-through configuration — observee_agents/auth/mcpauth.py:48 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/search/cloud_infrastructure.py:145` · Credential pass-through configuration — observee_agents_old/search/cloud_infrastructure.py:145 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/auth/mcpauth.py:48` · Credential pass-through configuration — observee_agents_old/auth/mcpauth.py:48 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/providers/gemini_provider.py:33` · Credential pass-through configuration — observee_agents_old/providers/gemini_provider.py:33 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/providers/openai_provider.py:34` · Credential pass-through configuration — observee_agents_old/providers/openai_provider.py:34 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents_old/search/cloud_infrastructure.py:44` · Credential pass-through configuration — observee_agents_old/search/cloud_infrastructure.py:44 · Credential pass-through configuration — agent relays sensitive credentials
- `observee_agents/providers/openai_provider.py:34` · Credential pass-through configuration — observee_agents/providers/openai_provider.py:34 · Credential pass-through configuration — agent relays sensitive credentials

## Proposed change
The attached patch removes the 12 lines above. If the behavior is intended, the fix is to declare it instead: list the host under `permissions.network` (or the MCP manifest) and say in the README why the package needs it; the next crawl will re-score it with the declaration taken into account.

## How this will be verified
Nothing is "verified safe" by assertion. When a new version is published, KillerSkills re-runs it in the honeypot and the verdict page updates; you can trigger it early from the verdict page ("Re-scan after I publish a fix"). Reply here or at [email protected] if you believe the verdict is wrong; disputes are reviewed by a person and the outcome is published on the verdict page.

_Proposed through killerskills.ai/threats by a user of the package, under their own GitHub account. The evidence is public; the package was never modified by KillerSkills._
# or from a terminal, under your own account:
gh repo fork observee-ai/mcp-agent-system --clone && cd mcp-agent-system
curl -s https://killerskills.ai/skills/pypi/mcp-agents/0.0.28/patch.diff | git apply --unidiff-zero
git checkout -b killerskills/0.0.28 && git commit -am "mcp-agents: Credential pass-through configuration"
gh pr create --fill --body-file <(curl -s https://killerskills.ai/skills/pypi/mcp-agents/0.0.28/patch.md)

We count proposals opened, not merged: a merge shows up as a new version that the crawl re-runs. Disputes: the maintainer can contest the verdict from its page; a person reviews it and the outcome is published.