← knock@r1

Propose a patch

A fix the maintainer can act on, with the evidence attached. It opens under your GitHub account in your browser; KillerSkills holds no token and never modifies the package. The fix is verified the only way we verify anything: the next crawl re-runs the new version in the honeypot. 66 · Caution

Evidence

The sandbox observed nothing beyond the static findings; the proposal cites those.

Diff · removes 4 caught lines

Download .patch
diff --git a/README.md b/README.md
--- a/README.md
+++ b/README.md
@@ -64,1 +64,0 @@
-> Add this line to your project's `CLAUDE.md` so the agent uses knock when it pays off:
@@ -82,1 +81,0 @@
-<summary><b>🖥️ Optional: use knock yourself from the terminal</b></summary> <br> You never *need* these, but they're handy. | Command | When you'd use it | |--
@@ -242,1 +240,0 @@
-<summary><b>Do I need an API key or a paid model?</b></summary> No. Indexing and search are fully deterministic and local. The only thing that uses an API is th
diff --git a/src/knock/extractors/js.py b/src/knock/extractors/js.py
--- a/src/knock/extractors/js.py
+++ b/src/knock/extractors/js.py
@@ -25,1 +25,0 @@
-_SPACE = re.compile(r"[ \t\r\f\v 

]+")

Zero-context hunks: apply with git apply --unidiff-zero fix.patch on the tagged source of r1. If the behavior is intended, declare it (host under permissions.network, a line in the README) instead of removing it; the next crawl scores declarations.

Issue / PR body

Title: knock: Collapsed <details> block carrying instructions (KillerSkills verdict caution 66)

## What the honeypot observed
KillerSkills ran **knock@r1** in an isolated sandbox (decoy credentials, recording proxy, syscall trace; engine 1.8.1) and scored it **CAUTION 66/100**. Summary: no network, touches nothing outside the project, writes no memory.

- See the findings below.

Full trace and findings: https://killerskills.ai/skills/glama/knock/r1

## Findings with a location
- `README.md:242` · Collapsed <details> block carrying instructions — README.md:242 · Collapsed <details> block carrying instructions
- `README.md:82` · Collapsed <details> block carrying instructions — README.md:82 · Collapsed <details> block carrying instructions
- `src/knock/extractors/js.py:25` · Hidden zero-width characters detected — src/knock/extractors/js.py:25 · Hidden zero-width characters detected — may conceal content
- `README.md:64` · Instructs the agent to modify its persistent memory or instruction files — README.md:64 · Instructs the agent to modify its persistent memory or instruction files · informational: not an instruction file

## Proposed change
The attached patch removes the 4 lines above. If the behavior is intended, the fix is to declare it instead: list the host under `permissions.network` (or the MCP manifest) and say in the README why the package needs it; the next crawl will re-score it with the declaration taken into account.

## How this will be verified
Nothing is "verified safe" by assertion. When a new version is published, KillerSkills re-runs it in the honeypot and the verdict page updates; you can trigger it early from the verdict page ("Re-scan after I publish a fix"). Reply here or at [email protected] if you believe the verdict is wrong; disputes are reviewed by a person and the outcome is published on the verdict page.

_Proposed through killerskills.ai/threats by a user of the package, under their own GitHub account. The evidence is public; the package was never modified by KillerSkills._
# or from a terminal, under your own account:
gh repo fork HasanGilani/knock --clone && cd knock
curl -s https://killerskills.ai/skills/glama/knock/r1/patch.diff | git apply --unidiff-zero
git checkout -b killerskills/r1 && git commit -am "knock: Collapsed <details> block carrying instructions"
gh pr create --fill --body-file <(curl -s https://killerskills.ai/skills/glama/knock/r1/patch.md)

We count proposals opened, not merged: a merge shows up as a new version that the crawl re-runs. Disputes: the maintainer can contest the verdict from its page; a person reviews it and the outcome is published.